db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Oystein Grovlen - Sun Norway <Oystein.Grov...@Sun.COM>
Subject Re: [jira] Commented: (DERBY-1176) Stored prepared statements in the SYSIBM schema are not updated on upgrade
Date Thu, 20 Apr 2006 12:59:24 GMT
Dag H. Wanvik (JIRA) wrote:

> Minor nit-picks:
> 
> - EmbedDatabaseMetaData.java
> 
>   * Code readability:
>   
>   if ((removeSYSIBMonly && isSYSIBM) || !removeSYSIBMonly) {
>      <do something>
>   }
> 
>   might be more readable as:
> 
>   if (removeSYSIBMonly && !isSYSIBM) {
>        // do nothing
>   } else {
>        <do something>
>   }
> 

Another and IMHO even more readable alternative is:

if (isSYSIBM || !removeSYSIBMonly) {
       <do something>
}


-- 
Øystein

Mime
View raw message