db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bryan Pendleton (JIRA)" <derby-...@db.apache.org>
Subject [jira] Updated: (DERBY-349) setByte() with executeBatch causes hang with client if mapping is invalid, e.g. setByte to DATE
Date Sat, 01 Apr 2006 23:51:34 GMT
     [ http://issues.apache.org/jira/browse/DERBY-349?page=all ]

Bryan Pendleton updated DERBY-349:
----------------------------------

    Attachment: derby-349-testFixes.diff

Attached is 'derby-349-testFixes.diff', which is a patch proposal to resolve this issue. 

The diff is a tad hard to read, so here are some notes. The proposed patch does the following:

1) Adds a utility routine called 'checkForInvalidConversion' to parameterMapping.java. This
routine knows how to hunt through a SQLException chain looking for the exception which indicates
a data conversion error. I added this routine because I needed to change the 2 "judge" routines
to teach them how to deal with a BatchUpdateException's underlying cause, and I didn't want
to make the same change in 2 places, so I extracted the common code from the 2 "judge" routines
into a shared routine and modified it there.

2) Modifies parameterMapping.java so that the batch tests are always run. Formerly, the batch
tests had some conditional logic in them allowing them to be skipped for certain data type
combinations for the DerbyNetClient. That logic is no longer needed, since the DerbyNetClient
now works.

3) Updates the master output files for the JDK 1.4 and JDK 1.5 runs of parameterMapping.java
under the DerbyNetClient framework.

I did *not* update the JDK 1.6 master file, because I do not have a JDK 1.6 environment here.
If somebody who has access to that environment could please:
a) Apply this patch
b) Run java -Dframework=DerbyNetClient org.apache.derbyTesting.functionTests.harness.RunTest
jdbcapi/parameterMapping.java under 1.6
c) Attach the parameterMapping.out that they get from their run to this issue

then I will inspect the parameterMapping.out diffs for JDK 1.6, ensure that they are reasonable,
and re-post the diff with those changes.

Please have a look at this patch when you get a chance. It would be nice to re-enable these
tests and resolve this JIRA issue.


> setByte() with executeBatch causes hang with client if mapping is invalid, e.g. setByte
to DATE
> -----------------------------------------------------------------------------------------------
>
>          Key: DERBY-349
>          URL: http://issues.apache.org/jira/browse/DERBY-349
>      Project: Derby
>         Type: Bug
>   Components: Network Client, Network Server
>     Versions: 10.1.1.0
>     Reporter: Daniel John Debrunner
>     Assignee: Bryan Pendleton
>     Priority: Minor
>  Attachments: derby-349-testFixes.diff
>
> setByte() followed by an addBatch() and then an executeBatch causes a hang.
> May apply to any setXXX call that will result in any invalid conversion, possibly only
those conversions handled by the client.
> See the test jdbcapi/parameterMapping, look for this bug number in the code, to see the
cases disabled when running with the client.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message