db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sunitha Kambhampati (JIRA)" <derby-...@db.apache.org>
Subject [jira] Commented: (DERBY-901) Remove use of String(byte[]) constructors in network server leading to non-portable behaviour
Date Fri, 14 Apr 2006 21:23:04 GMT
    [ http://issues.apache.org/jira/browse/DERBY-901?page=comments#action_12374573 ] 

Sunitha Kambhampati commented on DERBY-901:

Thanks Kathey for looking at the patch. 

Are you running the server with -Dfile.encoding=UTF16 ?  The problem will reproduce only when
server is running with a native encoding where the value 20 is mapped  to a different value
as in UTF16.

I have a phase2  patch that fixes the remaining occurrences of the default string contructor
in DRDAConnThread - ie writeSQLDIAGCI and the trace method. in readAndSetParams. 

The char value of 20 is same in UTF-8 and US-ASCII.    

The SQLERRMC_MESSAGE_DELIMITER is used in SystemProcedures. I'll see we can use that in DRDAConnThread.

> Remove use of String(byte[]) constructors in network server leading to non-portable behaviour
> ---------------------------------------------------------------------------------------------
>          Key: DERBY-901
>          URL: http://issues.apache.org/jira/browse/DERBY-901
>      Project: Derby
>         Type: Bug

>   Components: Network Server
>     Reporter: Daniel John Debrunner
>     Assignee: Sunitha Kambhampati
>  Attachments: Derby901.p1.diff.txt, Derby901.p1.stat.txt, TestEnc.java
> These constructors use the Java default platform encoding to convert the bytes to a String,
this typically leads to bugs on platforms with different encodings.
> Replace with code using fixed conversion, or alternative mechanisms. 
> If the call is required its use should be commented as to why it is required.
> org.apache.derby.impl.drda.DRDAConnThread
> I generated this list using the Java search in eclipse for references to the constructors
> String(byte[])
> String(byte[],int,int) - no occurences found in java/drda

This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
For more information on JIRA, see:

View raw message