db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sunitha Kambhampati (JIRA)" <derby-...@db.apache.org>
Subject [jira] Updated: (DERBY-901) Remove use of String(byte[]) constructors in network server leading to non-portable behaviour
Date Wed, 19 Apr 2006 23:44:42 GMT
     [ http://issues.apache.org/jira/browse/DERBY-901?page=all ]

Sunitha Kambhampati updated DERBY-901:
--------------------------------------

    Attachment: for_10.1_derby901.p2.diff.txt
                for_10.1_derby901.p2.stat.txt

Thanks Kathey for committing the derby901.p2.diff.txt patch on trunk.

 I am attaching a p2 patch for  10.1 codeline ( for_10.1_derby901.p2.diff.txt).
The changes in this patch are similar to changes in derby901.p2.diff.txt.

----------------------------------------------------------------------------
DERBY901. Remove use of String(byte[]) constructors in network server leading to non-portable
behaviour

remove use of default String(byte[]) constructor in 
--  trace method in DRDAConnThread.readAndSetParams to print out the hex string of the bytes
.
--  use SQLERRMC_TOKEN_DELIMITER in SQLDIAGCI .

some cleanup 
 -- define the SQLERRMC_MESSAGE_DELIMITER in SystemProcedures and use that in DRDAConnThread.

Testing:
derbyall on linux /ibm142 ran OK with no new failures. 

Can someone please look at this patch.  Thanks. 

> Remove use of String(byte[]) constructors in network server leading to non-portable behaviour
> ---------------------------------------------------------------------------------------------
>
>          Key: DERBY-901
>          URL: http://issues.apache.org/jira/browse/DERBY-901
>      Project: Derby
>         Type: Bug

>   Components: Network Server
>     Reporter: Daniel John Debrunner
>     Assignee: Sunitha Kambhampati
>  Attachments: Derby901.p1.diff.txt, Derby901.p1.stat.txt, TestEnc.java, derby901.p2.diff.txt,
derby901.p2.stat.txt, for_10.1_derby901.p1.diff.txt, for_10.1_derby901.p1.stat.txt, for_10.1_derby901.p2.diff.txt,
for_10.1_derby901.p2.stat.txt
>
> These constructors use the Java default platform encoding to convert the bytes to a String,
this typically leads to bugs on platforms with different encodings.
> Replace with code using fixed conversion, or alternative mechanisms. 
> If the call is required its use should be commented as to why it is required.
> org.apache.derby.impl.drda.DRDAConnThread
> I generated this list using the Java search in eclipse for references to the constructors
> String(byte[])
> String(byte[],int,int) - no occurences found in java/drda

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message