db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sunitha Kambhampati (JIRA)" <derby-...@db.apache.org>
Subject [jira] Updated: (DERBY-900) Remove use of String(byte[]) and String(byte[], int, int) constructors in network client leading to non-portable behaviour
Date Thu, 27 Apr 2006 22:20:38 GMT
     [ http://issues.apache.org/jira/browse/DERBY-900?page=all ]

Sunitha Kambhampati updated DERBY-900:
--------------------------------------

    Attachment: derby900.p2_encodingChange.diff.txt

I am dividing the Derby900.p2.diff.txt into two separate patches after talking to kathey.
 

This patch derby900.p2_encodingChange.diff.txt  makes the encoding related change to remove
the non portable String.getBytes() method. 

-- use correct encoding UTF8 for sqlstate in NetConnectionReply.::parseSQLDCGRP(Sqlca[] rowsetSqlca,
int lastRow) 

Note: this code does not get exercised anywhere as explained in previous comment. Also code
coverage results shows that this method is not called anywhere in our tests. 

svn stat
M      java\client\org\apache\derby\client\net\NetConnectionReply.java

derbynetclientmats ran ok on linux/ibm142. 

The change itself is pretty simple.  The diff for this patch shows  more lines as changed
because of the indentation change as a result of adding a try block. 

Can someone please look at this patch. Thanks. 

> Remove use of String(byte[]) and String(byte[], int, int) constructors in network client
leading to non-portable behaviour
> --------------------------------------------------------------------------------------------------------------------------
>
>          Key: DERBY-900
>          URL: http://issues.apache.org/jira/browse/DERBY-900
>      Project: Derby
>         Type: Bug

>   Components: Network Client
>     Reporter: Daniel John Debrunner
>     Assignee: Sunitha Kambhampati
>      Fix For: 10.2.0.0
>  Attachments: Derby900.p2.diff.txt, TestEnc.java, derby900.diff.p1.txt, derby900.p2.stat.txt,
derby900.p2_encodingChange.diff.txt, derby900.stat.p1.txt, derby900.test.diff.txt, derby900.test.stat.txt,
for_10.1_derby900.diff.p1.txt, for_10.1_derby900.stat.p1.txt
>
> These constructors use the Java default platform encoding to convert the bytes to a String,
this typically leads to bugs on platforms with different encodings.
> Replace with code using fixed conversion, or alternative mechanisms. 
> If the call is required its use should be commented as to why it is required.
> org.apache.derby.client.am.ClobOutputStream - some existing bug?
> org.apache.derby.client.am.DateTime - see DERBY-877
> org.apache.derby.client.am.sqlca
> I generated this list using the Java search in eclipse for references to the constructors
> String(byte[])
> String(byte[],int,int)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message