db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel John Debrunner (JIRA)" <derby-...@db.apache.org>
Subject [jira] Commented: (DERBY-1137) Implement the new method introduced in CommonDataSource for Embedded Driver
Date Tue, 04 Apr 2006 18:08:46 GMT
    [ http://issues.apache.org/jira/browse/DERBY-1137?page=comments#action_12373153 ] 

Daniel John Debrunner commented on DERBY-1137:
----------------------------------------------

Not sure -  it seems the foundation that this is being built on has gone in a strange direction.

EmbedXAConnection40 extends EmbedPooledConnection40 instread of EmbedXAConnection.

That's a concern to me. This approach has lead to 11 real methods being copied into EmbedXAConnection40
 from EmbedXAConnection
to save copying two new un-implemented methods. Seems a strange choice to me.

Why not have EmbedXAConnection40 extend EmbedXAConnection. and then we would only have two
methods copied
across EmbedPooledConnection40  and EmbedXAConnection40, rather than 11 across the current
mix.


> Implement the new method introduced in CommonDataSource for Embedded Driver
> ---------------------------------------------------------------------------
>
>          Key: DERBY-1137
>          URL: http://issues.apache.org/jira/browse/DERBY-1137
>      Project: Derby
>         Type: Sub-task

>   Components: JDBC
>  Environment: jdk1.6 jdbc4.0
>     Reporter: Anurag Shekhar
>     Assignee: Anurag Shekhar
>      Fix For: 10.2.0.0
>  Attachments: derby-1137.diff, derby-1137_2.diff, derby-1137_3.diff, stat.out
>


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message