Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm
Precedence: bulk
Reply-To: <derby-dev@db.apache.org>
Message-ID: <12761752.1143636210068.JavaMail.jira@ajax>
Date: Wed, 29 Mar 2006 13:43:30 +0100 (BST)
From: "Kristian Waagan (JIRA)" <derby-dev@db.apache.org>
To: derby-dev@db.apache.org
Subject: [jira] Commented: (DERBY-1149) 'jdbc40/StatementTest.junit' fails
 under DerbyNetClient
In-Reply-To: <1002121520.1143202220148.JavaMail.jira@ajax>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

    [ http://issues.apache.org/jira/browse/DERBY-1149?page=comments#action_12372240 ] 

Kristian Waagan commented on DERBY-1149:
----------------------------------------

This patch will (and does) fail, due to the way SQLStates are compared. I will brush up the patch, only changing things in StatementTest, were this testing was not good enough (all tests, not only the one that failed here).

David, can you explain why you have set the SQLState to "25000.S.1", and not to "25001"?
Is the former an SQLState encoding exception category, as described in the class comments for SQLState.java?

Do we want to use the invalid trasaction state also for XA connections? I see it has been added in EmbedXAConnection. Is the CANNOT_CLOSE_ACTIVE_XA_CONNECTION wrong/deprecated for XA connections?

Besides from these questions, I think the patch is good to go, but I would appreciate if it was held back until the questions above were answered and I had the time to add some fixes to StatementTest.


> 'jdbc40/StatementTest.junit' fails under DerbyNetClient
> -------------------------------------------------------
>
>          Key: DERBY-1149
>          URL: http://issues.apache.org/jira/browse/DERBY-1149
>      Project: Derby
>         Type: Test
>   Components: Regression Test Failure, Test
>     Versions: 10.2.0.0
>  Environment: JDK 1.6 (b76 used, believed to apply to all)
>     Reporter: Kristian Waagan
>     Assignee: David Van Couvering
>  Attachments: DERBY-1149-StatementTestFaiure.diff
>
> One of the tests in jdbc40/StatementTest.junit fails with the following message:
> "Attempt to shutdown framework: DerbyNetClient
> 0 add
> > ....F.
> > There was 1 failure:
> > 1) testIsClosedWhenClosingConnectionInInvalidState(org.apache.derbyTesting.functionTests.tests.jdbc4.StatementTest)junit.framework.ComparisonFailure: Unexpected exception thrown: Cannot close a connection while a global transaction is still active. expected:<java.sql.Connection.close() requested while a transaction is in progress on the connection.The transaction remains active, and the connection cannot be closed...> but was:<Cannot close a connection while a global transaction is still active...>
> > FAILURES!!!
> > Tests run: 5,  Failures: 1,  Errors: 0
> Test Failed.
> *** End:   StatementTest jdk1.6.0-beta2 DerbyNetClient 2006-03-24 12:53:22 ***"
> The reason is that the exception message text has been changed. This comparison is only done when running DerbyNetClient, because SQLState was not implemented there.
> The checkin that caused the error:
> "Author: davidvc
> Date: Thu Mar 23 16:55:44 2006
> New Revision: 388309
> URL: http://svn.apache.org/viewcvs?rev=388309&view=rev
> Log:
> DERBY-839 (Partial).  Internationalize Connection.java.  Also upgraded
> the "i18n lint" test to be a little more intelligent, and to not exit
> on the first failure.
> Passes derbynetclientmats.  All changes are client-specific so derbyall
> was not run."
> A

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira