Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm
Precedence: bulk
Reply-To: <derby-dev@db.apache.org>
Message-ID: <1163969243.1142846919934.JavaMail.jira@ajax>
Date: Mon, 20 Mar 2006 09:28:39 +0000 (GMT)
From: "Kristian Waagan (JIRA)" <derby-dev@db.apache.org>
To: derby-dev@db.apache.org
Subject: [jira] Commented: (DERBY-1097) Add tests for Statement.isClosed()
In-Reply-To: <2085899103.1142009858952.JavaMail.jira@ajax>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

    [ http://issues.apache.org/jira/browse/DERBY-1097?page=comments#action_12371051 ] 

Kristian Waagan commented on DERBY-1097:
----------------------------------------

Answering Rick's comments of 17th of March.

1) As is already stated, this test can be run from any suite by simply adding it with the .junit extension. I do not want to add it to the existing jdbc4 suite, because this suite is only run under DerbyNetClient (and tests embedded behavior at the same time - ie. it runs tests for two different frameworks under one framework).

Generally, we can follow the existing scheme by adding the names of the tests we want to run in files under functionTests/suites (with the .junit extension, not .java), or we can create a more complex suite() method in a test file. Since the latter solution breaks the way things are currently done, the former is preferred.

I was a bit confused when looking at the suites. I initially thought a suite would be run in all frameworks, except from those explicitly excluded. It seems a suite is only run under the specified framework.
Am I correct in assuming the class must then be added to two different suites?
One for embedded and one for DerbyNetClient? (does run under DerbyNet)

Also, for running only StatementTest, use "RunTest jdbc4/StatementTest.junit". Then add -Dframework to specify framework to run under.

2) I expected the bug to be fixed shortly, and it already is!
Besides, the test is not included in any suite yet, so it would not be run and cause problems for anyone.

3) I will.
New patch will be uploaded after addressing David's comments.

> Add tests for Statement.isClosed()
> ----------------------------------
>
>          Key: DERBY-1097
>          URL: http://issues.apache.org/jira/browse/DERBY-1097
>      Project: Derby
>         Type: Sub-task
>   Components: Test
>     Versions: 10.2.0.0
>  Environment: JDBC4 / JDK 1.6
>     Reporter: Kristian Waagan
>     Assignee: Kristian Waagan
>  Attachments: StatementTest.java, StatementTest.java-v1, StatementTestSetup.java, StatementTestSetup.java-v1
>
> Add tests for Statement.isClosed() (implemented as part of DERBY-953).
> The tests are already written, but because of some "confusion" and diverging paths regarding how to get connections when running JUnit tests, they are held back.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira