db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Knut Anders Hatlen (JIRA)" <derby-...@db.apache.org>
Subject [jira] Commented: (DERBY-1095) Closing an embedded connection does not seem to close associated EmbedStatements
Date Mon, 13 Mar 2006 17:16:16 GMT
    [ http://issues.apache.org/jira/browse/DERBY-1095?page=comments#action_12370210 ] 

Knut Anders Hatlen commented on DERBY-1095:
-------------------------------------------

Dan Debrunner wrote:

> I do think it needs to be fixed, I don't think the Connection having
> a list of open statements and calling close on them is the way to
> go.

In the client driver, NetConnection maintains a WeakHashMap with all
open statements. When the connection is marked as closed, it will call
markClosed() on the open statements. I'm afraid I don't see why it's a
bad idea to do the same in EmbedConnection. Could you please explain?

> Closing an embedded connection does not seem to close associated EmbedStatements
> --------------------------------------------------------------------------------
>
>          Key: DERBY-1095
>          URL: http://issues.apache.org/jira/browse/DERBY-1095
>      Project: Derby
>         Type: Bug
>   Components: JDBC
>     Versions: 10.2.0.0
>     Reporter: Kristian Waagan
>     Assignee: Daniel John Debrunner
>     Priority: Minor
>  Attachments: Derby1095Repro.java
>
> Closing an embedded connection (calling EmbedConnection.close()) does not seem to close
associated EmbedStatements. 
> The severity of the bug is not determined. The least severe case is that the internal
EmbedStatement variable 'active' is not updated accordingly, the most severe case is that
the the resources bound to EmbedStatement will not be viable for garbage collection until
the EmbedStatement itself is (if user keeps references to it).
> If methods on the statement are called, Derby will correctly throw an NoCurrentConnection
exception, but the close() method is still never called automatically.
> The problem also seem to extend down to ResultSet.isClosed(), but this is probably due
to the bug in EmbedStatement.
> Problem detected while fixing DERBY-953; implement Statement.isClosed().

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message