db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Olav Sandstaa (JIRA)" <derby-...@db.apache.org>
Subject [jira] Commented: (DERBY-1133) Split jdbc4 tests so that the suite can be run independently under the embedded and DerbyNetClients like other Derby test suites
Date Wed, 22 Mar 2006 09:53:05 GMT
    [ http://issues.apache.org/jira/browse/DERBY-1133?page=comments#action_12371408 ] 

Olav Sandstaa commented on DERBY-1133:
--------------------------------------

Hi Rick, thanks for fixing up the jdbc4 suite to make it possible to run using the standard
test frameworks.

Some minor comments to your patch:

1. I think the StartTestConnection.java test could be removed from the test suite. This test
tested that the previously used metods for creating a connection to the database worked. With
your change to get the connections using ij.startJBMS, this test basically runs connection.close.

2. The following files can be removed (if you do 1.):

      jdbc4/StartTestConnection.java
      jdbc4/TestConnection.java

3. A tiny comment: the files for the jdbc4 test code was basically TAB free before your check-in.....

> Split jdbc4 tests so that the suite can be run independently under the embedded and DerbyNetClients
like other Derby test suites
> --------------------------------------------------------------------------------------------------------------------------------
>
>          Key: DERBY-1133
>          URL: http://issues.apache.org/jira/browse/DERBY-1133
>      Project: Derby
>         Type: Improvement
>   Components: Test
>     Versions: 10.2.0.0
>     Reporter: Rick Hillegas
>     Assignee: Rick Hillegas
>  Attachments: bug1133.diff, bug1133_rev2.diff
>
> Right now the jdbc4 suite runs under the DerbyNetClient. However, under the covers, the
tests also run themselves against the embedded client. We should fix these tests so that the
whole suite can run just under DerbyNetClient or just under the embedded client.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message