db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Satheesh Bandaram <sathe...@Sourcery.Org>
Subject Re: ColumnMetaData methods not in use - would like to comment out
Date Sat, 01 Apr 2006 02:29:41 GMT
I vote for removing this dead code. Probably was created during
development and didn't really get used in the final version. Dead code
like this makes maintaining product little harder, confuse developers
and reduces our code coverage numbers. :-)

Satheesh

David W. Van Couvering wrote:

> Oh, two more:
>
> private void guessParameterMetaDataBasedOnSupportedDriverType(int,
> boolean, int, int)
> guessParameterMetaData(int, int, int, int, int) (only called by the
> method above)
>
> Thanks,
>
> David
>
> David W. Van Couvering wrote:
>
>> There are some methods in client.am.ColumnMetaData.java that are not
>> being used at all right now, and rather than internationalize their
>> messages, which are somewhat odd, I'd rather comment them out.
>>
>> They are
>>
>> void guessInputParameterMetaData(int, int)
>> void guessInputParameterMetaData(int, int, int)
>> void guessOutputParameterMetaData(int, int, int)
>>
>> I double-checked -- they are not in our documented APIs, and these
>> methods are not part of java.sql.ResultSetMetaData, which this class
>> implements.
>>
>> Anyone object?
>>
>> David
>>
>
>
>


Mime
View raw message