Great idea, Myrna, thanks! I was a little uncomfortable at the number
of canon files but couldn't think of an alternative...
David
Myrna van Lunteren wrote:
> Hi,
>
> I apologize for not paying closer attention to this bug sooner...I only
> realized the effect when david committed the change.
>
> I looked at some of the diffs, and I think for at least a number of
> jdk16 canons, a better alternative would be to add some sed-ing to the
> test harness' Sed.java class, and replace the string with something
> common, and update the 'original' master and canons for other jvms.
>
> It may seem like more work now, but I know from experience that
> maintaining canons is an uninteresting, bothersome task...
>
> To begin with, add a replacement line in Sed.java so that both
> 'java.sql.SQLException' and 'SQL Exception' get replaced by something
> common, for instance, 'xxSQL-Exception:xx '
>
> That should get rid of at least some of the canons. I am not sure how
> important it is to retain for instance the
> java.sql.SQLTransientConnectionException in checkDataSource.out, but I
> think the above should be pretty acceptable and a good first step to
> minimize the number of jdk16 canons...
>
> Myrna
>
> On 3/16/06, *Anurag Shekhar (JIRA)* <derby-dev@db.apache.org
> <mailto:derby-dev@db.apache.org>> wrote:
>
> [ http://issues.apache.org/jira/browse/DERBY-1105?page=all
> <http://issues.apache.org/jira/browse/DERBY-1105?page=all> ]
>
> Anurag Shekhar updated DERBY-1105:
> ----------------------------------
>
> Version: 10.2.0.0 <http://10.2.0.0>
> (was: 10.0.2.0 <http://10.0.2.0>)
>
> > derbyall failures due to change in exception type
> > -------------------------------------------------
> >
> > Key: DERBY-1105
> > URL: http://issues.apache.org/jira/browse/DERBY-1105
> <http://issues.apache.org/jira/browse/DERBY-1105>
> > Project: Derby
> > Type: Sub-task
> > Versions: 10.2.0.0 <http://10.2.0.0>
> > Environment: jdk 1.6
> > Reporter: Anurag Shekhar
> > Assignee: Anurag Shekhar
> > Attachments: derby-1105.diff.gz, derby-1105.stat
> >
> > due to change in exception type in embedded driver there are
> several failures in derbyall under jdk1.6. The out file ot the test
> case should be changed in such a way that it works on jdk1.6 and
> older jdk's without fails
>
> --
> This message is automatically generated by JIRA.
> -
> If you think it was sent incorrectly contact one of the administrators:
> http://issues.apache.org/jira/secure/Administrators.jspa
> -
> For more information on JIRA, see:
> http://www.atlassian.com/software/jira
>
>
|