db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Bryan Pendleton <bpendle...@amberpoint.com>
Subject Re: [jira] Updated: (DERBY-1080) Connection reset when using security mechanism=EUSRIDPWD results in protocol error.
Date Wed, 08 Mar 2006 02:27:05 GMT
Sunitha Kambhampati (JIRA) wrote:
>     Attachment: Derby1080.diff.txt

Hi Sunitha,

I took a very quick look at your patch, and wanted to offer the following feedback:

1) Resetting database state information when re-using a database object seems
like a reasonable behavior to me. I think it would be nice to use the same
overall naming conventions and techniques that Deepa established in DERBY-1002,
so maybe you might want to investigate whether your new code should go into
a database.reset() method rather than being open-coded in DRDAConnThread.

2) A couple more comments in the code in the "try" block in testSecMecWithConnPooling()
would be nice, to make it more clear as to why you are re-using the connection and
what the expected result is. In particular, I found myself unable to explain why
some of the master files show this test succeeding, and some of the master files
show it getting an exception, so some comments would help me understand why the
various master files have the contents that they do.

3) Lastly, would your test have been any different if you had used
ConnectionPoolDataSource.getPooledConnection(String user, String password)
rather than ConnectionPoolDataSource.getPooledConnection()? I guess I don't
really understand how the user's identification information is intended to be
passed around when using pooled connections, and the JDBC javadocs did not
provide an obvious answer.



View raw message