db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rick Hillegas (JIRA)" <derby-...@db.apache.org>
Subject [jira] Commented: (DERBY-1097) Add tests for Statement.isClosed()
Date Fri, 17 Mar 2006 21:00:47 GMT
    [ http://issues.apache.org/jira/browse/DERBY-1097?page=comments#action_12370883 ] 

Rick Hillegas commented on DERBY-1097:
--------------------------------------

Hi Kristian,

1) I'm afraid I'm missing some context here. It looks like you have some idea of how these
JUnit tests for jdbc4 can be wired into a suite. This will be particularly useful as developers
add more JUnit tests for jdbc4. Could you create that suite and provide instructions for how
to run it under all the supported environments?

2) I also don't understand the motivation behind checking in a test which fails in an expected
environment.

3) When you resubmit the patch, it will really help the reviewer if you package up the whole
submission as a diff-style patch. Thanks.

> Add tests for Statement.isClosed()
> ----------------------------------
>
>          Key: DERBY-1097
>          URL: http://issues.apache.org/jira/browse/DERBY-1097
>      Project: Derby
>         Type: Sub-task
>   Components: Test
>     Versions: 10.2.0.0
>  Environment: JDBC4 / JDK 1.6
>     Reporter: Kristian Waagan
>     Assignee: Kristian Waagan
>  Attachments: StatementTest.java, StatementTest.java-v1, StatementTestSetup.java, StatementTestSetup.java-v1
>
> Add tests for Statement.isClosed() (implemented as part of DERBY-953).
> The tests are already written, but because of some "confusion" and diverging paths regarding
how to get connections when running JUnit tests, they are held back.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message