db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Knut Anders Hatlen (JIRA)" <derby-...@db.apache.org>
Subject [jira] Commented: (DERBY-970) Add new metadata methods to network client driver
Date Fri, 24 Mar 2006 13:11:39 GMT
    [ http://issues.apache.org/jira/browse/DERBY-970?page=comments#action_12371723 ] 

Knut Anders Hatlen commented on DERBY-970:
------------------------------------------

Kathey wrote:

> 1) What is the soft upgrde impact of this change if any?

There should be no soft upgrade impact of this change.

getClientInfoProperties() contains a query that always returns an
empty result set, so you can upgrade and downgrade as much as you
want, both softly and hard, and still see the same result.

getSchemas() uses an existing system procedure (SQLTABLES) which is
available in soft upgrade mode. The system procedure is slightly
modified, but it's interface is unchanged, so I can't see how it
should be affected by soft upgrade.

And since both the methods are new in JDBC 4, old clients won't notice
any change.

> DERBY-1075 was checked in last night so you could probably go ahead
> and add soft upgrade tests for this.

It doesn't seem like the upgrade test is quite ready, yet. At least, I
get a *huge* diff when I try to run it. I'm also not sure it's easy to
add tests for new JDBC 4 methods (that is, without heavy use of
reflection).

> 2) Did you run the derbynetmats suite (JCC) with your change?

Yes. No failures.

> 3) I was thinking to add coverage for specific client/server version
>    code paths, it would be good to add tests to:
>  java/testing/org/apache/derbyTesting/functionTests/tests/junitTests/compatibility/JDBCDriverTest
>   and run with the original client release and then run with:
> . original 10.1 client / trunk server
>    original 10.1 server/ trunk client

Again, I don't think it's trivial to add tests for new JDBC 4 methods
to that test. I also don't thinks these methods are very interesting
to have in a compatibility test. getClientInfoProperties() just
returns an empty result set, getSchemas() is supposed to fail with an
old server, and old clients don't even have the methods, so there
isn't much compatibility to test.

> Add new metadata methods to network client driver
> -------------------------------------------------
>
>          Key: DERBY-970
>          URL: http://issues.apache.org/jira/browse/DERBY-970
>      Project: Derby
>         Type: Sub-task
>   Components: JDBC
>     Reporter: David Van Couvering
>     Assignee: Knut Anders Hatlen
>      Fix For: 10.2.0.0
>  Attachments: derby-970-part1-v1.diff, derby-970-part1-v1.stat, derby-970-part2-v1.diff,
derby-970-part2-v1.stat, derby-970-part3-v1.diff, derby-970-part3-v1.stat
>
> Implement new JDBC 4.0 DatabaseMetaData methods in the client driver:
>   - supportsStoredFunctionsUsingCallSyntax()
>   - autoCommitFailureClosesAllResultSets()
>   - getClientInfoProperties()
>   - providesQueryObjectGenerator()
>   - getSchemas()
>   - getRowIdLifetime()

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message