db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kristian Waagan (JIRA)" <derby-...@db.apache.org>
Subject [jira] Updated: (DERBY-1097) Add tests for Statement.isClosed()
Date Mon, 20 Mar 2006 10:13:03 GMT
     [ http://issues.apache.org/jira/browse/DERBY-1097?page=all ]

Kristian Waagan updated DERBY-1097:

    Attachment: DERBY-1097-2a.stat

Answering David's comments of 18th of March, and uploading 'DERBY-1097-2a.diff' (patch deprecates
previous patches).

Committing sound test code that is known to fail beacause of another bug in Derby must be
allowed in my opinion, as long as they are not included in any suites and will be fixed shortly.
Also, in this case, the fact that the test code works for embedded is an indication (but not
a guarantee) that the test code is sound - the same code is run for DerbyNetClient. The error
happens in the one-time setup code in StatementTestSetup.setUp(), but it is now gone because
the bug is already fixed.
Finally, I have not submitted a patch for enabling the test, thus it would not cause problems
for anyone.

I have removed the exclamation marks in the assertion messages.

I don't understand this comment: "It's a little odd to me that you run an embedded test under
the DerbyNetClient framework."
Did you look at the old/initial submission, or have I forgotten to remove some comments?
I agree that what the jdbc4 suite does is odd, but that is not my code. I initially wrote
StatementTest so that it could be added to the jdbc4 suite, but was convinced this was not
the best idea because of how it is run.
StatementTest itself can be run under embedded or DerbyNetClient. It doesn't run under DerbyNet
(JCC), because the driver does not support JDBC4.

A new suite will be created, but I'm not sure what is the best solution yet, so I would like
some comments on it.
Should I create a new JDBC4 suite, say 'jdbc40', then add this to derbyall and derbynetclientmats?
All JVMs except JDK 1.6 will be excluded and so will running under DerbyNet be.

> Add tests for Statement.isClosed()
> ----------------------------------
>          Key: DERBY-1097
>          URL: http://issues.apache.org/jira/browse/DERBY-1097
>      Project: Derby
>         Type: Sub-task
>   Components: Test
>     Versions:
>  Environment: JDBC4 / JDK 1.6
>     Reporter: Kristian Waagan
>     Assignee: Kristian Waagan
>  Attachments: DERBY-1097-2a.diff, DERBY-1097-2a.stat, StatementTest.java, StatementTest.java-v1,
StatementTestSetup.java, StatementTestSetup.java-v1
> Add tests for Statement.isClosed() (implemented as part of DERBY-953).
> The tests are already written, but because of some "confusion" and diverging paths regarding
how to get connections when running JUnit tests, they are held back.

This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
For more information on JIRA, see:

View raw message