Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm
Precedence: bulk
Reply-To: <derby-dev@db.apache.org>
Received-SPF: pass (asf.osuosl.org: local policy)
Date: Fri, 24 Feb 2006 09:20:44 +0100
From: Knut Anders Hatlen <Knut.Hatlen@Sun.COM>
Subject: Re: [DRDA] Question about DRDAStatement.initialize() method
In-reply-to: <58ed70f50602231615q28eb7d70obd05d43cb5261a64@mail.gmail.com>
To: derby-dev@db.apache.org
Message-id: <wjo8slq9yxpf.fsf@sun.com>
Organization: Sun Microsystems
MIME-version: 1.0
Content-type: text/plain; charset=us-ascii
User-Agent: Gnus/5.1007 (Gnus v5.10.7) Emacs/22.0.50 (usg-unix-v)
References: <58ed70f50602231411h2c33db9egf30a7590c793b690@mail.gmail.com>
 <43FE3CBB.3030600@sbcglobal.net> <87y801tz1v.fsf@sun.com>
 <58ed70f50602231615q28eb7d70obd05d43cb5261a64@mail.gmail.com>

Deepa Remesh <dremesh@gmail.com> writes:

> Thanks Knut and Kathey. I will open a jira issue for changing use of
> initialize or do it in a separate patch. For your answers to
> question3, I have a small concern. Please see below.
>
>
>> >>3. Is my comment for the new reuse method() okay? specifically, the
>> >>comment about fields which should not be reset?
>> >>"This method should reset all members of this class except the
>> >>following which will be set at initial creation or set explicitly in
>> >>the code: database, pkgnamcsn, pkgcnstkn, pkgid, pkgsn"
>> >>
>> >>
>> >>
>> > If these can be reset too that would be good and then get set whereever
>> > the get set just for completeness.
>>
>> If you reset these variables, you'll need to call
>> DRDAStatement.setPkgnamcsn() and DRDAStatement.setDatabase() later. In
>> DRDAConnThread, setPkgnamcsn() and setDatabase() are not called after
>> DRDAStatement.initialize(), so you'll have to add those calls there.
>
> pkgnamcsn is the key used for statements added to stmtTable. It seems
> to the basis for reusing statements. Resetting it seems a bit odd to
> me. Code in Database.newDRDAStatement will look like this:
>
>         DRDAStatement stmt = getDRDAStatement(pkgnamcsn);
>         if (stmt != null) {
>             stmt.reset();
>             stmt.setPkgnamcsn(pkgnamcsn);
>             stmt.setDatabase(this);
>         }

I agree, it's odd. The way DRDAStatements are reused, pkgnamcsn and
database rarely (if ever) have to be touched. I think it's OK not to
reset them.

You might also consider getting rid of pkgcnstkn, pkgid and pkgsn
since they are stored in pkgnamcsn anyway. If you remove them, we only
have two variables that aren't reset like the others.

I also think it's a good idea to add a comment before the declarations
of the instance variables saying something like

  // NOTE!
  //
  // Since DRDAStatements are reused, ALL variables (except 'database'
  // and 'pkgnamcsn') should be set to their default values in
  // reset().

-- 
Knut Anders