Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm
Precedence: bulk
Reply-To: <derby-dev@db.apache.org>
Received-SPF: pass (asf.osuosl.org: local policy)
Date: Thu, 23 Feb 2006 21:01:08 +0100
From: Kristian Waagan <Kristian.Waagan@Sun.COM>
Subject: Re: [Db-derby Wiki] Update of "DerbyContributorChecklist" by
 RichardHillegas
In-reply-to: <20060223193928.8637.18255@ajax.apache.org>
To: Derby Development <derby-dev@db.apache.org>
Message-id: <43FE1484.8010401@Sun.com>
Organization: Sun Microsystems Inc.
MIME-version: 1.0
Content-type: text/plain; charset=ISO-8859-1; format=flowed
Content-transfer-encoding: 7BIT
User-Agent: Mozilla/5.0 (X11; U; SunOS i86pc; en-US; rv:1.7.12) Gecko/20050930
 Thunderbird/1.0.7 Mnenhy/0.7.2.0
References: <20060223193928.8637.18255@ajax.apache.org>

Apache Wiki wrote:
> Dear Wiki user,
> 
> You have subscribed to a wiki page or wiki category on "Db-derby Wiki" for change notification.
> 
> The following page has been changed by RichardHillegas:
> http://wiki.apache.org/db-derby/DerbyContributorChecklist
> 
> ------------------------------------------------------------------------------
>   ||Copyright Notice||Every java file in your patch must start with the Apache [http://www.apache.org/licenses/LICENSE-2.0.html#apply  copyright notice]. See the existing Derby Java files for examples. ||
>   ||Tests||Don't forget to include regression tests with your patch.||
>   ||Coding Standards||The Derby community has not approved a common body of coding standards. Individual contributors have found the following standards useful: [http://java.sun.com/docs/codeconv/html/CodeConvTOC.doc.html  Java Coding Standards] and [http://wiki.apache.org/geronimo/CodingStandards  Geronimo Coding Standards].||
> + ||Comments||Make sure you comment your code.||
> + ||Tabs||Set your tabs at 4 spaces. This was the original Cloudscape convention. With this setting your code should look readable.||
>   

Hi,

I know the issue has been discussed before, but is it deliberate that 
the checklist does not specify whether it is preferred to use tabs or 
spaces for indentation?

While I'm at it, if we say spaces are preferred over tabs, is it okay to 
contribute patches that (only) fix indentation for individual files?
The primary reason for doing this (for me) is that files that mix space 
and tab indentation can result in very ugly diffs.

As mentioned earlier, most editors/IDEs are able to cope with this 
issue, so it's no problem when working with the code in these tools.


--
Kristian