Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm
Precedence: bulk
Reply-To: <derby-dev@db.apache.org>
Received-SPF: neutral (asf.osuosl.org: local policy)
Message-ID: <43E8A926.1090603@apache.org>
Date: Tue, 07 Feb 2006 06:05:26 -0800
From: Daniel John Debrunner <djd@apache.org>
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US;
 rv:1.7.3) Gecko/20040910
MIME-Version: 1.0
To: derby-dev@db.apache.org
Subject: Re: [patch] cleanup of org.apache.derby.iapi.services.cache.ClassSize
References: <43E721C5.2050305@it.fts-vn.com> <43E7764D.1080605@sun.com>
 <43E805BC.2090909@it.fts-vn.com> <43E8205D.1070802@apache.org>
 <43E825D6.3080400@it.fts-vn.com> <43E829FC.7050903@apache.org>
 <43E82E34.9090704@it.fts-vn.com> <43E89D5E.3010804@sbcglobal.net>
In-Reply-To: <43E89D5E.3010804@sbcglobal.net>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit

Kathey Marsden wrote:

> Shortly after the client contribution,  Jeremy changed all the client
> files to have a uniform style.

Though I don't think there was any followup on how to ensure the new
format was kept to, or if patches with a different style (to what?)
should be accepted.

> I have recently been thinking that I would like to see the Network
> Server code on the trunk and 10.1 changed to match client, especially
> since many changes  include client and server modifications and we may
> be able to share code in the future.  We could pick some  weekend in a
> few weeks and see if Jeremy would be willing to make a pass of the drda
> tree, which is not really that many files.   We spend too much time
> messing with this issue.  Thoughts?

Doesn't have to be Jeremy, could be anyone. If a non-committer does this
it might be better for them to provide a script that performs the
re-formatting rather than a big patch, easier to ensure there's no
problem with the changes.

Dan.