Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm
Precedence: bulk
Reply-To: <derby-dev@db.apache.org>
Message-ID: <383324572.1139272558342.JavaMail.jira@ajax.apache.org>
Date: Tue, 7 Feb 2006 01:35:58 +0100 (CET)
From: "Myrna van Lunteren (JIRA)" <derby-dev@db.apache.org>
To: derby-dev@db.apache.org
Subject: [jira] Commented: (DERBY-683) Use correct encoding for
 ClobOutputStream on client
In-Reply-To: <781151520.1131155779823.JavaMail.jira@ajax.apache.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

    [ http://issues.apache.org/jira/browse/DERBY-683?page=comments#action_12365367 ] 

Myrna van Lunteren commented on DERBY-683:
------------------------------------------

I looked at the deltas and it looks reasonable to me.

I ran the suite on windows 2000 with 
   - jdk15 on windows 2000 - which was fine -
   - jdk14 - which was skipped, and failed when I commented that out
   - ibm15 - which should've skipped, but seemed to work, except for plopping 'process exception: null" to the console:
-----------------------
....lse^derbyTesting.encoding=UTF-16^runwithjdk13=false^runwithibm15=false^runwithjdk12=false^hostName=localhost^runwithibm13=false -Dsuitename=encodingTests:encodingTests -Dtopsuitename=encodingTests org.apache.derbyTesting.functionTests.harness.RunTest jdbcapi/lobStreams.java
Process exception: null
Generated report: encodingTests_report.txt
------------------------

It doesn't look like this patch is to blame for the non-skipping of ibm15, I'll have a look at that.

But I am wondering about why you tried to have that skipped, was that because of that Process exception? 

> Use correct encoding for ClobOutputStream on client
> ---------------------------------------------------
>
>          Key: DERBY-683
>          URL: http://issues.apache.org/jira/browse/DERBY-683
>      Project: Derby
>         Type: Bug
>   Components: Network Client
>     Versions: 10.1.1.1, 10.1.1.0
>  Environment: all
>     Reporter: Sunitha Kambhampati
>     Assignee: Deepa Remesh
>      Fix For: 10.2.0.0
>  Attachments: ascii.txt, clob.java, derby-683.diff, derby-683_tests.diff, derby-683_tests.status
>
> In client, there is code in ClobOutputStream which uses this api - new String(byte[]).   Per the java api http://java.sun.com/j2se/1.4.2/docs/api/java/lang/String.html#String(byte[]) ,this will construct a string by decoding the array of bytes using the platform's default character set. 
> org.apache.derby.client.am.ClobOutputStream is used for Clob.setAsciiStream and the write methods  use the String(byte[]) which is incorrect because it will use the default platform encoding. Per the jdbcapi , this should use ascii encoding. 
> In areas related to Clobs, also check for other places where  String(byte[]) is used,as it may not be the desired behavior. 
> Dan pointed this problem here : http://issues.apache.org/jira/browse/DERBY-463?page=comments#action_12356742

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira