Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm
Precedence: bulk
Reply-To: <derby-dev@db.apache.org>
Message-ID: <2081639677.1140453625929.JavaMail.jira@ajax.apache.org>
Date: Mon, 20 Feb 2006 17:40:25 +0100 (CET)
From: "A B (JIRA)" <derby-dev@db.apache.org>
To: derby-dev@db.apache.org
Subject: [jira] Commented: (DERBY-815) Prevent unneeded object creation and
 excessive decoding in parseSQLDTA_work()
In-Reply-To: <1939819753.1137421580307.JavaMail.jira@ajax.apache.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

    [ http://issues.apache.org/jira/browse/DERBY-815?page=comments#action_12367049 ] 

A B commented on DERBY-815:
---------------------------

Okay, so the unmodified test fails in embedded.  But the master file in master/prepStmt.out is not just for embedded; it also serves as the default  master file for server mode if nothing else is found.  In the case of server mode with a 1.4 jvm, the 1.5 masters don't apply, and since there's nothing else to use the default master/prepStmt.out will be used.  Which is (I think) why that master file exists, even if the test doesn't run in embedded mode.

The unmodified test passes in server mode with 1.4; the modified test fails in server mode with 1.4--and my guess is that that's not deliberate.  So I think what's required here is that someone run the test  in server mode against 1.4 and then copy that master file to master/prepStmt.out.  Based on the "itch" philosophy, that someone doesn't have to be you--but in the meantime, any tests run with 1.4 will (so far as I understand it) fail with your changes.

That's how I understand it, anyways.  I'm not blocking the patch from being committed, I'm just pointing out a potential master-update problem that could lead to a new nightly test failure.  *shrug*

> Prevent unneeded object creation and excessive decoding in parseSQLDTA_work()
> -----------------------------------------------------------------------------
>
>          Key: DERBY-815
>          URL: http://issues.apache.org/jira/browse/DERBY-815
>      Project: Derby
>         Type: Sub-task
>   Components: Network Server, Performance
>     Versions: 10.1.1.0, 10.1.1.1, 10.1.1.2, 10.1.2.0, 10.1.2.1, 10.1.3.0, 10.1.2.2, 10.0.2.2
>     Reporter: Knut Anders Hatlen
>     Assignee: Dyre Tjeldvoll
>     Priority: Minor
>      Fix For: 10.2.0.0
>  Attachments: d815_regress.diff, d815_regress.java, derby-815.diff, derby-815.html, derby-815_2.diff, derby-815_2.stat, derbyall_report_2.txt
>
> Reported by Kathey Marsden in DERBY-212:
> In reviewing the Network Server Code and profiling there were several
> areas that showed potential for providing performance
> improvement. Functions that need optimizing to prevent unneeded object
> creation and excessive decoding: parseSQLDTA_work()

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira