Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm
Precedence: bulk
Reply-To: <derby-dev@db.apache.org>
Received-SPF: neutral (asf.osuosl.org: local policy)
Message-ID: <20060227180125.33763.qmail@web81610.mail.mud.yahoo.com>
Date: Mon, 27 Feb 2006 10:01:25 -0800 (PST)
From: Jeff Levitt <derby@mylevita.com>
Subject: Re: [jira] Commented: (DERBY-809) Incorrect documentation for
 'NetworkServerControl.logConnections(boolean)'
To: derby-dev@db.apache.org
In-Reply-To: <788774199.1141062562487.JavaMail.jira@ajax.apache.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit

Thanks Kristian,

We usually do an edit before any release, and
capitalization consistency gets picked up then.  So I
think we should commit it.

Thanks again!

--- "Kristian Waagan (JIRA)" <derby-dev@db.apache.org>
wrote:

>     [
>
http://issues.apache.org/jira/browse/DERBY-809?page=comments#action_12367995
> ] 
> 
> Kristian Waagan commented on DERBY-809:
> ---------------------------------------
> 
> I reviewed Jeff's patch (derby809.diff), and it
> looks good. I do have two comments:
> 
> 1) The DOCTYPE tags have been changed, but I don't
> know what they should be like. Since Jeff has built
> the HTML files, I take they are good.
> 
> 2) The capitalization of "connection number" should
> be consistent. Both "..connection number..." and
> "...Connection Number..." are used.
> 
> These are not blockers, and I leave it up to the
> committers whether it is a go or not. 
> Thank you for updating the manuals Jeff!
> 
> 
> > Incorrect documentation for
> 'NetworkServerControl.logConnections(boolean)'
> >
>
--------------------------------------------------------------------------
> >
> >          Key: DERBY-809
> >          URL:
> http://issues.apache.org/jira/browse/DERBY-809
> >      Project: Derby
> >         Type: Bug
> >   Components: Documentation, Javadoc
> >     Versions: 10.0.2.1, 10.1.1.2, 10.1.2.1
> >     Reporter: Kristian Waagan
> >     Priority: Minor
> >      Fix For: 10.2.0.0, 10.1.3.0
> >  Attachments: DERBY-809-1b-javadoc.diff,
> DERBY-809-1b-javadoc.stat, derby809.diff,
> radminconfigdb2jdrdalogconnections.html,
> tadminlogfile.html
> >
> > The documentation for
> 'NetworkServerControl.logConnections(boolean)'
> states that Derby logs both connections and
> disconnections. As of 10.1.2.1 and (all) earlier
> releases, this is not true. The documentation should
> be corrected to avoid confusing users.
> > The thought of adding logging of disconnections
> has also been posted on derby-dev.
> > Byran Pendleton identified the following
> documentation with the incorrect description:
> >
>
http://db.apache.org/derby/javadoc/publishedapi/org/apache/derby/drda/NetworkServerControl.html
> >
>
http://db.apache.org/derby/docs/10.1/adminguide/radminconfigdb2jdrdalogconnections.html
> >
>
http://db.apache.org/derby/docs/10.0/manuals/admin/hubprnt23.html
> >
>
http://db.apache.org/derby/docs/10.1/adminguide/tadminlogfile.html
> > Should we fix this in 10.0? If yes, please update
> fix versions for this issue.
> 
> -- 
> This message is automatically generated by JIRA.
> -
> If you think it was sent incorrectly contact one of
> the administrators:
>   
>
http://issues.apache.org/jira/secure/Administrators.jspa
> -
> For more information on JIRA, see:
>    http://www.atlassian.com/software/jira
> 
>