Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm
Precedence: bulk
Reply-To: <derby-dev@db.apache.org>
Message-ID: <1230237950.1139851768583.JavaMail.jira@ajax.apache.org>
Date: Mon, 13 Feb 2006 18:29:28 +0100 (CET)
From: "A B (JIRA)" <derby-dev@db.apache.org>
To: derby-dev@db.apache.org
Subject: [jira] Commented: (DERBY-815) Prevent unneeded object creation and
 excessive decoding in parseSQLDTA_work()
In-Reply-To: <1939819753.1137421580307.JavaMail.jira@ajax.apache.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

    [ http://issues.apache.org/jira/browse/DERBY-815?page=comments#action_12366217 ] 

A B commented on DERBY-815:
---------------------------

> I wanted this repro to be run both with DerbyNet and DerbyNetClient, but based on 
> the content of suites/derbynetmats.runnall and suites/derbynetclientmats.runall there 
> doesn't appear to be any tests that are actually run in both frameworks. So which test 
> should I extend? Any help on this would be much appreciated. Thanks.

There are two places where the tests for a given suite are specified: the first is <suite>.runall, which specifies individual tests to run; the second is <suite>.properties, in which you can specify additional suites to run with the same configuration as the current suite.

Thus, while derbynetmats.runall and derbynetclientmats.runall do not share any individual tests, a look at derbynetclientmats.properties shows the following:

framework=DerbyNetClient
suites= derbynetclientmats derbynetmats

As I understand it, this means that all tests in derbynetclientmats.runall AND derbynetmats.runall will run as part of the "derbynetclientmats" suite using the DerbyNetClient framework.  So as long as you add the new test case to  a test that is in derbynetmats.runall, it will also run as part of derbynetclientmats (assuming the test is not  listed in the DerbyNetClient.exclude file).

That said, if you can find an appropriate test in either derbynetmats.runall or jdbcapi.runall, I think you could use that since both of those suites are run as part of derbynetmats and thus both are also run as part of derbynetclientmats.  As I said, though, you'll just have to make sure whatever test you choose is _not_ listed in either DerbyNet.exclude nor DerbyNetClient.exclude

Does that help?

> Prevent unneeded object creation and excessive decoding in parseSQLDTA_work()
> -----------------------------------------------------------------------------
>
>          Key: DERBY-815
>          URL: http://issues.apache.org/jira/browse/DERBY-815
>      Project: Derby
>         Type: Sub-task
>   Components: Network Server, Performance
>     Versions: 10.1.1.0, 10.1.1.1, 10.1.1.2, 10.1.2.0, 10.1.2.1, 10.1.3.0, 10.1.2.2, 10.0.2.2
>     Reporter: Knut Anders Hatlen
>     Priority: Minor
>      Fix For: 10.2.0.0
>  Attachments: d815_regress.diff, d815_regress.java, d815_regress.stat, d815_regress_derbyall_report.txt, derby-815.diff, derby-815.stat, derby.log, derbyall_report.txt
>
> Reported by Kathey Marsden in DERBY-212:
> In reviewing the Network Server Code and profiling there were several
> areas that showed potential for providing performance
> improvement. Functions that need optimizing to prevent unneeded object
> creation and excessive decoding: parseSQLDTA_work()

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira