db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Knut Anders Hatlen <Knut.Hat...@Sun.COM>
Subject Re: [jira] Updated: (DERBY-100) Add support for insert functionality using JDBC 2.0 updatable resultset apis
Date Fri, 10 Feb 2006 09:28:03 GMT
"Fernanda Pizzorno (JIRA)" <derby-dev@db.apache.org> writes:

>      [ http://issues.apache.org/jira/browse/DERBY-100?page=all ]
> Fernanda Pizzorno updated DERBY-100:
> ------------------------------------
>     Attachment: DERBY-100-4.diff
>                 DERBY-100-4.stat
> Thank you for looking into the patch Bryan Pendleton. 
> The change to the getBoolean() method that you mentioned (deleting
> the exit trancing), that was an accident that happened while I was
> manually merging changes. I am sorry I did not notice it before. I
> am attaching a patch to fix it.
> For rowInserted(), my intention was to make the implementation of
> this method as similar as possible to that of the rowDeteled() and
> rowUpdated() methods. Since these two methods do not have entry
> trancing, I removed it from the rowInserted() method.

Why not add tracing to rowDeleted() and rowUpdated()? :)

> I have only run derbylang with this new patch since the changes
> where so small. Please let me know if you think it is necessary that
> I run derbyall and I will do it.

Since this is a change in the client driver, isn't derbynetclient a
better test than derbylang?

Knut Anders

View raw message