db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Knut Anders Hatlen <Knut.Hat...@Sun.COM>
Subject Re: [jira] Updated: (DERBY-821) Client driver: Implicitly close exhausted result sets on the server
Date Mon, 13 Feb 2006 14:26:36 GMT
"Bernt M. Johnsen" <Bernt.Johnsen@Sun.COM> writes:

>>>>>>>>>>>>> Bernt M. Johnsen wrote (2006-02-13 10:08:47):
>> >>>>>>>>>>>> Bryan Pendleton wrote (2006-02-12
19:56:12):
>> > Knut Anders Hatlen (JIRA) wrote:
>> > >New patch (DERBY-821-v2.diff) which addresses issues identified by
>> > >Bryan and Kathey.
>> > 
>> > This patch looks good to me. It applied cleanly to the current trunk,
>> > and derbyall passed in my sandbox. Thank you for adding the additional
>> > tests, I think they are quite valuable. The protocol test in
>> > particular was interesting; I had not known about that technique before.
>> 
>> 
>> Looks good to me too! I'll commit it as soon as Knut Anders makes I
>> new version which applies cleanly to head of trunk.
>
> It applies cleanly. My mistake. Will commit.

Thanks, Bernt! And thank you, Bryan, for reviewing and providing
helpful feedback!

-- 
Knut Anders


Mime
View raw message