db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Myrna van Lunteren <m.v.lunte...@gmail.com>
Subject Re: [jira] Commented: (DERBY-903) Remove use of String(byte[]) and String(byte[], int, int) constructors in testing leading to non-portable behaviour
Date Thu, 16 Feb 2006 17:52:44 GMT
Hi,

I decided to just print out a simple descriptive String in this
not-currently-hit-in-these-tests error situation.
With Jira down, I'm attaching an updated coalesceTests.java and
resultset.java to this mail.

Myrna


On 2/15/06, Myrna van Lunteren (JIRA) <derby-dev@db.apache.org> wrote:
>
>    [ http://issues.apache.org/jira/browse/DERBY-903?page=comments#action_12366571
> ]
>
> Myrna van Lunteren commented on DERBY-903:
> ------------------------------------------
>
> Hi Andrew,
>
> Thx for looking at this.
>
> I would say, if no one objects, to go ahead with this change at this
> point, I will make a follow up patch to clean that bit up.
>
> The same construct is used in coalesceTests...The code doesn't get used in
> either test. It looks like it was copied out of metadata test, but I don't
> think it's done like this there (anymore), it's a odd piece of code.
>
>
>
>
> > Remove use of String(byte[]) and String(byte[], int, int) constructors
> in testing leading to non-portable behaviour
> >
> -------------------------------------------------------------------------------------------------------------------
>
> >
> >          Key: DERBY-903
> >          URL: http://issues.apache.org/jira/browse/DERBY-903
> >      Project: Derby
> >         Type: Bug
> >   Components: Test
> >     Versions: 10.2.0.0
> >     Reporter: Daniel John Debrunner
> >     Assignee: Myrna van Lunteren
> >      Fix For: 10.2.0.0
> >  Attachments: DERBY-903_021306.diff, DERBY-903_021306.stat
> >
> > These constructors use the Java default platform encoding to convert the
> bytes to a String, this typically leads to bugs on platforms with different
> encodings.
> > Replace with code using fixed conversion, or alternative mechanisms.
> > If the call is required its use should be commented as to why it is
> required.
> > org.apache.derbyTesting.functionTests.tests.jdbcapi.blobclob4BLOB
> > org.apache.derbyTesting.functionTests.tests.jdbcapi.resultset
> > org.apache.derbyTesting.functionTests.tests.lang.coalesceTests
> > org.apache.derbyTesting.functionTests.tests.store.streamingColumn
> > I generated this list using the Java search in eclipse for references to
> the constructors
> > String(byte[])
> > String(byte[],int,int) (no occurrences in java/testing)
>
> --
> This message is automatically generated by JIRA.
> -
> If you think it was sent incorrectly contact one of the administrators:
>   http://issues.apache.org/jira/secure/Administrators.jspa
> -
> For more information on JIRA, see:
>    http://www.atlassian.com/software/jira
>
>

Mime
View raw message