db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Van Couvering (JIRA)" <derby-...@db.apache.org>
Subject [jira] Commented: (DERBY-819) Provide JDBC4 SQLException subclasses support in Embedded driver
Date Thu, 16 Feb 2006 23:31:25 GMT
    [ http://issues.apache.org/jira/browse/DERBY-819?page=comments#action_12366720 ] 

David Van Couvering commented on DERBY-819:
-------------------------------------------

Dan, thanks for catching these, multiple eyes really help.  

I thought I just didn't understand some of the internals when I saw the SystemProcedures diffs.
 Anurag, you *did* run a full set of tests with this patch?  If so, I'm surprised that this
got through.

I had suggested in http://issues.apache.org/jira/browse/DERBY-819#action_12364274 that Anurag
use a simpler factory model.  Wouldn't this kind of approach close the NPE window?

When you say "the code would have used SQLException", what code are you talking about?

Also, although InternalDriver could potentially be responsible for generating SQLExceptions,
it seems to me a new class helps divide concerns.  It doesn't seem to me InternalDriver should
be in the business of generating SQLExceptions...  That said, I do recognize adding new classes,
though more readable and coherent, can contribute to the overall size of derby.jar

David

> Provide JDBC4 SQLException subclasses support in Embedded driver
> ----------------------------------------------------------------
>
>          Key: DERBY-819
>          URL: http://issues.apache.org/jira/browse/DERBY-819
>      Project: Derby
>         Type: Sub-task
>   Components: JDBC
>  Environment: all
>     Reporter: Anurag Shekhar
>     Assignee: Anurag Shekhar
>     Priority: Minor
>  Attachments: .derby-819_2.stat, derby-819-onlyforreview.diff, derby-819.diff, derby-819_2.diff,
stat.out
>


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message