db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew McIntyre (JIRA)" <derby-...@db.apache.org>
Subject [jira] Commented: (DERBY-903) Remove use of String(byte[]) and String(byte[], int, int) constructors in testing leading to non-portable behaviour
Date Thu, 16 Feb 2006 00:03:45 GMT
    [ http://issues.apache.org/jira/browse/DERBY-903?page=comments#action_12366565 ] 

Andrew McIntyre commented on DERBY-903:
---------------------------------------

Hi Myrna,

I took a look at the latest patch for this, DERBY-903_021306.diff.  It looks good, except
it's not clear to me that the diff in resultset.java would actually be encoding-safe. It looks
like adding the contents of getBytes.toString() to the StringBuffer would be the same as new
String(getBytes()), although this code is in an exception handler, so it's not clear to me
from the code or the output that this code is ever reached. Let me know if you want to take
a closer look at that, otherwise I'll go ahead and commit and you can follow up later.

> Remove use of String(byte[]) and String(byte[], int, int) constructors in testing leading
to non-portable behaviour
> -------------------------------------------------------------------------------------------------------------------
>
>          Key: DERBY-903
>          URL: http://issues.apache.org/jira/browse/DERBY-903
>      Project: Derby
>         Type: Bug
>   Components: Test
>     Versions: 10.2.0.0
>     Reporter: Daniel John Debrunner
>     Assignee: Myrna van Lunteren
>      Fix For: 10.2.0.0
>  Attachments: DERBY-903_021306.diff, DERBY-903_021306.stat
>
> These constructors use the Java default platform encoding to convert the bytes to a String,
this typically leads to bugs on platforms with different encodings.
> Replace with code using fixed conversion, or alternative mechanisms. 
> If the call is required its use should be commented as to why it is required.
> org.apache.derbyTesting.functionTests.tests.jdbcapi.blobclob4BLOB
> org.apache.derbyTesting.functionTests.tests.jdbcapi.resultset
> org.apache.derbyTesting.functionTests.tests.lang.coalesceTests
> org.apache.derbyTesting.functionTests.tests.store.streamingColumn
> I generated this list using the Java search in eclipse for references to the constructors
> String(byte[])
> String(byte[],int,int) (no occurrences in java/testing)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message