db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Deepa Remesh <drem...@gmail.com>
Subject Re: [jira] Updated: (DERBY-614) Execution failed because of a Distributed Protocol Error
Date Thu, 16 Feb 2006 21:21:28 GMT
> Attached is d614_a.diff,

Thanks Bryan for attaching the patch with code change plus test. I
looked at your patch and ran your new test with and without the code
changes. I get expected results.

I have just one small comment:
In the prepStmt test, it would be good to close the statement and
result set before exiting the 'jira614Test_a' method since client
driver currently does not free up statements till they are closed.
When I think about it, maybe it is okay to leave it as-is. It may help
in covering paths where statement is not explicilty closed. What do
you think?

It is really nice of you to work on this so fast. I am amazed by how
you created a repro for the (seemingly) intermittent problem. Wish I
can do the same for the intermittent problem found with my first patch
for derby-210. I'll feel more comfortable in submitting the patch if I
am able to do that.

Thanks,
Deepa

Mime
View raw message