db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daniel John Debrunner <...@apache.org>
Subject Re: Derby commit process
Date Wed, 01 Mar 2006 00:09:13 GMT
Andrew McIntyre wrote:

> On 2/28/06, Daniel John Debrunner <djd@apache.org> wrote:
> 
>>I'm less clear on the others, reviewed by who? finalized according to what?
> 
> 
> * reviewed by who? It's possible to add a screen with a user browser
> and comment field when that part of the workflow is chosen. The
> reviewer can then pick themselves, or a review that was posted to the
> list could be entered by someone else. The information as to who the
> reviewer was then becomes part of the bug information.

I guess my concern here that 'patch reviewed' is not really a state or a
check box item. I think we should encourage multiple reviews, "more eyes
on the code", having anything that seems to indicate no more reviews are
required doesn't seem a good thing.

Dan.


Mime
View raw message