db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Bryan Pendleton <bpendle...@amberpoint.com>
Subject Re: NetXAResource - duplicate constants?
Date Wed, 22 Feb 2006 23:08:17 GMT
Daniel John Debrunner wrote:
>  the client
> should not have its own set of constants, and instead just use the ones
> defined in XAException. 

I agree. I had the same reaction when I was reading an early version
of the patch for DERBY-960: see
http://www.nabble.com/Re%3A-jira-Updated%3A-%28DERBY-960%29-Client-xa-prepare-returns-XA_OK-instead-of-XA_RDONLY-for-a-read-only-transaction-p2942222.html

XARETVAL_XARDONLY and XARETVAL_XAOK in NetXAResource.java seem to
duplicate the values XA_OK and XA_RDONLY from
http://java.sun.com/j2ee/1.4/docs/api/javax/transaction/xa/XAResource.html

+1 to simply using the constants defined in
javax.transaction.xa.XAException and javax.transaction.xa.XAResource
instead of defining duplicate constants in NetXAResource.java.

thanks,

bryan


Mime
View raw message