db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Army <qoz...@sbcglobal.net>
Subject Re: [jira] Updated: (DERBY-815) Prevent unneeded object creation and excessive decoding in parseSQLDTA_work()
Date Mon, 20 Feb 2006 15:18:29 GMT
Army wrote:
> Dyre Tjeldvoll (JIRA) wrote:
>>      [ http://issues.apache.org/jira/browse/DERBY-815?page=all ]
>> Dyre Tjeldvoll updated DERBY-815:
>> ---------------------------------
>>     Attachment: derby-815_2.diff
>>                 derby-815_2.stat
>>                 derbyall_report_2.txt
>> New patch with testcase for the regression. Please review, but I think 
>> it would be wise to delay committing until AB has had a chance to run 
>> his ODBC tests with the patch. Thanks.
> Sorry for the delay here, I have a lot going on.  I'll try to sync up 
> with this latest patch and run the ODBC tests this weekend...

I applied the patch and ran my ODBC tests with no failures.  I haven't had time 
to do a full review of the patch, but I did skim through and it looks like 
things are well commented now--so thanks for doing that.

One note: the patch only updates the master files for jdk15; the "default" 
master file (master/prepStmt.out) wasn't updated, so if you run the new test 
with any JVM earlier than 1.5, there will be a diff.  If you have time to try 
that out and include that master update in this patch, that'd be good.

Thanks for taking the time to follow-up on my questions/concerns.

View raw message