db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daniel John Debrunner <...@apache.org>
Subject Re: [jira] Updated: (DERBY-614) Execution failed because of a Distributed Protocol Error
Date Thu, 16 Feb 2006 22:09:35 GMT
Bryan Pendleton wrote:

> Deepa Remesh wrote:
>> In the prepStmt test, it would be good to close the statement and
>> result set before exiting the 'jira614Test_a' method since client
>> driver currently does not free up statements till they are closed.
>> When I think about it, maybe it is okay to leave it as-is. It may help
>> in covering paths where statement is not explicilty closed. What do
>> you think?
> Thanks for looking at the patch, and for confirming the results
> in your environment.
> I don't have an opinion about the question you raise; I can see
> both sides.
> Does anybody else have an opinion on this?

I would say explicitly close the object. If we want to test what happens
if JDBC objects are not closed by the application, then that should be a
specific test, not by chance in another test. Too easy for someone to
clean up this test later fixing the lack of close, thus removing the
"accidental" testing code path.


View raw message