db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David W. Van Couvering" <David.Vancouver...@Sun.COM>
Subject Re: [jira] Commented: (DERBY-819) Provide JDBC4 SQLException subclasses support in Embedded driver
Date Thu, 16 Feb 2006 21:31:36 GMT

Daniel John Debrunner wrote:


> I believe these were driven (according to the patch notes) because of
> the bug in 983. Ie. leave Util.notImplemented() as its old
> implementation so the client could (incorrectly) continue to call it,
> and modify the engine to use the new mechanism. Ie. the client wouldn't
> be using the new InternalDriver could, which it shouldn't.
> Now once, 983 is fixed, embedded can continue to call
> Util.notImplemented() and have Util.notImplemented() call
> InternalDriver.getSQLExceptionFactory().notImplemented();
> I.e. continue using the shorthand method to reduce footprint.

I see what you are saying, thanks.

> I think 983 should be committed first.
> I'll look at the patch for 819, and hopefully raise my veto, maybe it's
> ok to leave all the calls to
> InternalDriver.getSQLExceptionFactory().notImplemented()
> and someone can modify them to use a shorthand method later if they have
> the itch.

OK.  I actually have that itch and (if I'm still around and not on 
paternity leave) I may fix that as part of my checkin for 819


View raw message