db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daniel John Debrunner <...@apache.org>
Subject Re: [jira] Commented: (DERBY-435) jdbcapi/checkDataSource.java and jdbapi/checkDataSource30.java to tests should be changed or extended to test client DataSources
Date Thu, 16 Feb 2006 21:25:03 GMT
Kathey Marsden (JIRA) wrote:

>     [ http://issues.apache.org/jira/browse/DERBY-435?page=comments#action_12366675 ]

> Kathey Marsden commented on DERBY-435:
> --------------------------------------
> It looks to me like the checkDataSource.runTest() method gets run twice, once with checkDataSource
(xa suite) and once with checkDataSource30 (jdk14 suite)
> checkDataSource30 has the following code:
>                 tester.runTest(args);
> 		tester.checkXAHoldability();
> Removing tester.runTest and having checkXAHoldability create the database instead of
expecting it to be there all seems to work ok. So question is:
> do we need checkDataSource30 to call runtTest?

I think so. I think checkDataSource30 overides some of the instance
methods of checkDataSource to provide extra JDBC 3.0 specific testing on
the Connection and other JDBC objects. One example, I think, is to
perform JDBC Savepoint testing on all the ways we can obtain a connection.

It could be the tester.checkXAHoldability() could be separated into a
separate test XA check Data source test, but checkDataSource30 needs to


View raw message