db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daniel John Debrunner <...@apache.org>
Subject Re: [jira] Commented: (DERBY-819) Provide JDBC4 SQLException subclasses support in Embedded driver
Date Thu, 16 Feb 2006 20:30:13 GMT
David W. Van Couvering wrote:

> As far as I can tell, DERBY-983 only makes it so the notImplemented()
> method no longer has to live in Util.java.  I thought there was still a
> need for an exception factory so in JDBC4 we can create the appropriate
> SQLException subclass.  Am I missing something?

Not sure.

A lot of the changes in the original 819 patch was changing

Util.notImplemented()

to

InternalDriver.getSQLExceptionFactory().notImplemented();


I believe these were driven (according to the patch notes) because of
the bug in 983. Ie. leave Util.notImplemented() as its old
implementation so the client could (incorrectly) continue to call it,
and modify the engine to use the new mechanism. Ie. the client wouldn't
be using the new InternalDriver could, which it shouldn't.

Now once, 983 is fixed, embedded can continue to call
Util.notImplemented() and have Util.notImplemented() call
InternalDriver.getSQLExceptionFactory().notImplemented();
I.e. continue using the shorthand method to reduce footprint.

I think 983 should be committed first.

I'll look at the patch for 819, and hopefully raise my veto, maybe it's
ok to leave all the calls to
InternalDriver.getSQLExceptionFactory().notImplemented()
and someone can modify them to use a shorthand method later if they have
the itch.

As a general thought it is worrying when changes are made to work around
a bug, rather than fixing it, and then the bug is fixed first and then
the no longer needed work arounds are left in.

Dan.



Mime
View raw message