db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Bryan Pendleton <bpendle...@amberpoint.com>
Subject Re: [jira] Commented: (DERBY-515) Network Server should log server start and shutdown time to derby.log
Date Wed, 15 Feb 2006 23:20:30 GMT
 > I chose GMT to keep it consistent with what is used for Derby boot message.

Sounds good.

 > About using xxxxxxFILTERED-VERSION-NUMBERxxxxxx, I did'nt see other tests
 > doing it. I saw the current pattern in tests is to add master files with
 > version number to release/build.xml file. I would like to know what
 > problems you see if there are more files in this list.

Sorry, I shouldn't have introduced this red herring. I was remembering
the discussion of a few weeks ago:
in which there were a bunch of problems due to having release-specific
values in test output, and so I was sort of inventing a new mechanism
on the spot to see if it helped.

But I don't think it does; I think you should stick with the implementation
in your current patch proposal.

So, bottom line: thumbs up from me on your patch, and thanks for answering
my questions!



View raw message