db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Bryan Pendleton <bpendle...@amberpoint.com>
Subject Re: [jira] Commented: (DERBY-210) Network Server will leak prepared statements if not explicitly closed by the user until the connection is closed
Date Wed, 15 Feb 2006 21:51:28 GMT
Deepa Remesh wrote:
> On looking some more, I could narrow down the problem further and
> think the problem is in DRDAResultSet.close(). In this close() method,
> splitQRYDATA variable does not get reset.
...
> I think we should be resetting this in the close()
> method irrespective of my changes for DERBY-210.

Yes, absolutely.

That's clearly the right thing to do, and it's clearly a bug that
I introduced with the fix to DERBY-614. The close() method resets all
the DRDAResultSet state, and I overlooked this when I added the
splitQRYDTA variable.

Sorry about that, and thanks for tracking this down!

What's the right thing to do here? Should we re-open DERBY-614 and
have me work on that as a separate item? Or is it adequate just to
include

   splitQRYDTA = null;

in your changes for DERBY-210?

I suspect that the change really belongs with DERBY-614, but it's
going to be a blocker for you and it will take me some time to
develop and test a completely separate patch with focused repro, etc.

What do you suggest?

thanks,

bryan




Mime
View raw message