db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David W. Van Couvering" <David.Vancouver...@Sun.COM>
Subject Adding SUR tests to derbyall (was Re: [jira] Updated: (DERBY-934) create a set of JUnit tests for Scrollable Updatable Resultsets)
Date Wed, 15 Feb 2006 00:43:35 GMT
So, I pinged Andreas on the backchannel, and he responded that the 
failures with SURTest are expected (as we are still lacking some of the 
Scrollable Updatable ResultSet (SUR) functionality), that the 
SURQueryMixTest should pass when I appy the patch for DERBY-795, and 
that if I remove some printStackTrace debug calls from ConcurrencyTest 
that should run clean.

I made his recommended changes, and confirmed.

So, I would like to see these tests in derbyall.  I re-ran the tests 
with framework=DerbyNetClient and SURQueryMixTest and ConcurrencyTest 
both again pass.  They also pass running with the 1.3 JDK.  I have no 
idea if they will pass or succeed with the IBM JDK as I don't have 
access to that.

Under DerbyNetClient, SURTest has more/different failures and errors. 
Some of these appear to be related to null SQL States.  Andreas, perhaps 
you can look at these failures and tell me if they look OK.  For now I 
won't be adding SURTest to the derbynetclientmats suite.

I also ran with framework=DerbyNet and got hard stop failures saying a 
null username is not supported.

ConcurrencyTest currently has a long timeout so I don't think we should 
have it in derbyall unless we reduce the timeout

So, that all said, I am going to add the following:

- Add master for SURTest for embedded client that has all the expected 
failures.  Andreas, please make sure to update the master as more 
functionality comes in and the results change.

- Add SURTest and SURQueryMixTest to jdbcapi.runall.  NOTE that there 
may be failures with the IBM JDK tests related to this.

- Add SURQueryMixTest to derbynetclientmats.runall.  I'm holding off on 
SURTest.

- Holding off adding ConcurrencyTest to jdbcapi.runall and 
derbynetclientmats.runall until the timeout duration is reduced to a 
reasonable length

Please let me know if you have any comments.

Thanks,

David

David W. Van Couvering wrote:
> Hi, Andreas. Are you expecting these tests to pass?  In my environment 
> SURTest fails with 8 failures and 52 errors, SURQueryMixTest has 64 
> failures and 0 errors, and ConcurrencyTest fails on a lock timeout.
> 
> David
> 
> Andreas Korneliussen wrote:
> 
>> David W. Van Couvering wrote:
>>
>>> My JIRA rendering is completely broken, so I am unable to add a comment.
>>>
>>> I took a look at your patch file, but it appears to be incomplete?  
>>> It ends half way through a method in ConcurrencyTest.
>>>
>>
>> I just downloaded my diff from JIRA, and it was all ok. Maybe it was 
>> JIRA problem when you downloaded the patch ?
>>
>> Attached is the diff
>>
>> Andreas
>>
>>

Mime
View raw message