db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daniel John Debrunner <...@apache.org>
Subject Re: Review of DERBY-100 patch, anyone?
Date Tue, 07 Feb 2006 04:48:09 GMT
Dag H. Wanvik wrote:

> Hi,
> Fernanda uploaded a second version of the patch for DERBY-100 a week
> ago; is someone planning to have a look at it?

Just a general reminder that anyone can review a code patch, not just
committers. Looking at patches is another to get involved and start to
learn Derby. See the problem the contributor is trying to resolve and
see how they tackled it. If you don't understand the patch, ask a
question, sometimes it will be because the patch is wrong and it didn't
make sense because of that. Or ask for more comments if you feel the
code is not explained well, remember the code has to stand by itself
years from now, when the original context of the change is lost to time.


View raw message