db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Van Couvering (JIRA)" <derby-...@db.apache.org>
Subject [jira] Commented: (DERBY-840) International messages DatabaseMetaData to GetFileInputStreamAction in org.apache.derby.client.am
Date Wed, 08 Feb 2006 18:06:58 GMT
    [ http://issues.apache.org/jira/browse/DERBY-840?page=comments#action_12365603 ] 

David Van Couvering commented on DERBY-840:
-------------------------------------------

Hi, Narayanan.  My apologies for losing track of this patch.  Here are my comments

- TABLE_NAME_IS_NULL -- please change this message to "Table name can not be null."
- SECURITY_NO_SUCH_PROVIDER - please chain the underlying NoSuchProviderException
- SECURITY_NO_SUCH_ALGORITHM - please chain the underlying NoSuchAlgorithmException
- SECURITY_INVALID_ALGORITHM_PARAMETER - please chain the underlying InvalidAlgorithmParameterException
- SECURITY_INVALID_KEY - please chain the underlying InvalidKeyException

One thing you could do here is have a single message like "Security exception encountered,
see next exception for details" and then chain the underlying security exception.

- SECURITY_WRONG_KEY_LENGTH - You are replacing two very different this for two very separate
messages - "DES key has the wrong length" and 'sharedSecret key length error " + sharedSecret.length.
 I'd like to see this as two separate message ids, I am pretty sure the DES key and shared
secret key are not the same, and the second message includes the length of the key as a parameter,
which you have removed, and which might be very valuable information.

Thanks,

David



> International messages DatabaseMetaData to GetFileInputStreamAction in org.apache.derby.client.am
> -------------------------------------------------------------------------------------------------
>
>          Key: DERBY-840
>          URL: http://issues.apache.org/jira/browse/DERBY-840
>      Project: Derby
>         Type: Sub-task
>   Components: Network Client
>     Reporter: David Van Couvering
>     Assignee: V.Narayanan
>  Attachments: internationalization_840.diff, internationalization_840.stat
>


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message