db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bernt M. Johnsen" <Bernt.John...@Sun.COM>
Subject Re: [jira] Updated: (DERBY-100) Add support for insert functionality using JDBC 2.0 updatable resultset apis
Date Tue, 07 Feb 2006 12:44:28 GMT
>>>>>>>>>>>> Fernanda Pizzorno (JIRA) wrote (2006-01-25
13:59:11):
> In this new patch I have:
>  * changed moveToInsertRow in java/engine/org/apache/derby/impl/jdbc/EmbedResultSet.java
so that it will not create a new blank row each time
>  * changed the sqlState I have added from CANNOT_INSERT_AT_CURRENT_POSITION to NOT_POSITIONED_ON_INSERT_ROW
>  * changed the tests so that they will print sqlState and message for all exceptions
and walk down the SQLException chain
>  * added some more tests
>  * changed the behavior of insertRow when no updateXXX has been called before insertRow
is called. It now inserts a row with the row's default values.
> 
> Can someone please review this patch?

I've reviewed and tested it and found it ok. Although I wish we had a
more elegant way of doing inserts (and deletes and updates) than
creating SQL statements "under the hood".

> I have not updated the canon for updatableResultSet.java under j9_13
> and DerbyNet.

I know it's acceptable to commit without an update for the j9_13
canon, but does the same apply for DerbyNet?

If nobody objects, I'll commit this patch.

-- 
Bernt Marius Johnsen, Database Technology Group, 
Staff Engineer, Technical Lead Derby/Java DB
Sun Microsystems, Trondheim, Norway

Mime
View raw message