db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Deepa Remesh (JIRA)" <derby-...@db.apache.org>
Subject [jira] Updated: (DERBY-618) Make the client driver connection URL work when spaces are in the URL.
Date Wed, 01 Mar 2006 01:18:40 GMT
     [ http://issues.apache.org/jira/browse/DERBY-618?page=all ]

Deepa Remesh updated DERBY-618:
-------------------------------

    Attachment: derby-618-v1.diff
                derby-618-v1.status

Attaching a patch 'derby-618-v1.diff'. This is a one line change in ClientDriver.java. It
removes the space separator in the call to nextToken method in tokenizeDatabase method. This
allows use of database names with spaces.

With this patch, I can create and connect to databases with spaces in the path or name. After
connecting to such a database, I tried few simple operations. I did not get any exceptions.
I think Trejkaz was getting an exception because previously network server also did not support
database name with spaces. The problem at network server was resolved as part of DERBY-212/DERBY-814.
Before this patch, parsePKGNAMCSN used to return a string with space separators (return rdbnam
+ " " + rdbcolid + " " + pkgid + " " + secnumber + " " + pkgcnstknStr;). So, if the database
name had spaces in it, it would'nt work when the pkgnamcsn string is parsed later. This has
been already fixed in the trunk.

I have not added any new regression test for this patch since we will be able to run the test
only on Windows. I think test harness does not allow excluding tests based on an operating
system. I have repros to test this and I'll upload them shortly.

With the patch, I have run derbynetclientmats using Sun JDK 1.4.2 on Windows XP. No failures.
I would appreciate if someone can take a look at this patch.

> Make the client driver connection URL work when spaces are in the URL.
> ----------------------------------------------------------------------
>
>          Key: DERBY-618
>          URL: http://issues.apache.org/jira/browse/DERBY-618
>      Project: Derby
>         Type: Improvement
>   Components: Network Client
>     Versions: 10.1.1.0
>     Reporter: Trejkaz
>     Assignee: Deepa Remesh
>  Attachments: derby-618-v1.diff, derby-618-v1.status
>
> At present, if I want to connect to a database on a Derby server which has a space in
the path, there is no way to do it.
> This can be done with the embedded driver, and for consistency it would be good if it
worked for the client driver in the same fashion.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message