db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "V.Narayanan (JIRA)" <derby-...@db.apache.org>
Subject [jira] Commented: (DERBY-796) jdbc 4.0 specific Blob and Clob method support
Date Fri, 17 Feb 2006 14:46:26 GMT
    [ http://issues.apache.org/jira/browse/DERBY-796?page=comments#action_12366797 ] 

V.Narayanan commented on DERBY-796:
-----------------------------------

Thanx a ton for the detailed reviews and comments on the patch. I am working to get the issues
with this patch resolved. I am summarizing the issues reported as part of the reviews as a
series of points below.  I will fix them and resubmit the patch

Issue-1
-------
Javadoc needs to have @param/@return tags

Issue-2
-------

Some classes/methods do not have javadoc/comments

specifc case

ClientJDBCObjectfactory
ClientJDBCObjectFactoryImpl
ClientJDBCObjectFactoryImpl40

--> In this specific case I did'nt put in method level javadoc comments for the Impl classes
because they inherit the javadoc comments of the interface. If you still feel that they need
class level comments I will add these too.

Issue-3
-------
The indentation style is not consistent and makes the code harder
to read.

Issue-4
-------
In ClientConnectionPoolDataSource I don't see any reason to catch the SQLException since it's
just going
to be thrown again anyway.

Issue-5
-------
I am combining all the issues related to createDefaultFactoryImpl() here

createDefaultFactoryImpl() is called in the exception handler, but
the return value is discarded. I guess it is supposed to be returned.

The way exceptions are handled (in particular the use
of instanceof and throwing away the stack trace) is improper.

don't see much value in the createObject() method, since it's
just calling Class.forName(...).newInstance() and is just being
used once

Issue-6
-------

The method Configuration.atLeast() duplicates functionality found in
JVMInfo. 

Preferably, you could create a method supportsJDBC40() that
returns a boolean.

Issue-7
-------

moving ClientJDBCObjectFactoryImpl and ClientJDBCObjectFactoryImpl40 to net
package 

renaming method signatures inside this to be more generic

thanx once again
Narayanan

> jdbc 4.0 specific Blob and Clob method support
> ----------------------------------------------
>
>          Key: DERBY-796
>          URL: http://issues.apache.org/jira/browse/DERBY-796
>      Project: Derby
>         Type: New Feature
>   Components: JDBC
>     Versions: 10.2.0.0
>  Environment: jdbc 4.0 on all platforms
>     Reporter: V.Narayanan
>     Assignee: V.Narayanan
>     Priority: Minor
>      Fix For: 10.2.0.0
>  Attachments: ClientFrameworkExplanation_1.txt, ClientFramework_Explanation.txt, lob.diff,
lob_1.diff, lob_2.diff, lob_3.diff, lob_4.diff, lob_4.stat, lob_5.diff, lob_5.stat
>


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message