db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dag H. Wanvik (JIRA)" <derby-...@db.apache.org>
Subject [jira] Commented: (DERBY-965) DatabaseMetadata method supportsResultSetConcurrency returns wrong result on network client
Date Mon, 27 Feb 2006 14:57:45 GMT
    [ http://issues.apache.org/jira/browse/DERBY-965?page=comments#action_12367962 ] 

Dag H. Wanvik commented on DERBY-965:
-------------------------------------

Thanks for looking at this Bryan.

Bryan wrote:

> It would be nice to have comments in metadata_net.properties
> explaining the encoding, and in DatabaseMetaData.java explaining
> what's going on with the string tokenizers and pointing to the
> metadata_net.properties since the two files are sort of linked at the
> hip.

I'll do that and upload a new patch. 

> It's a bummer about the mixed-version incompatibilities, but I
> couldn't think of any easy way to make them better.

By changing the client's code the way I did (not changing the encoding
in the server, only correcting it's value), we should be OK (cf my
comments above):

Old clients - new server will still give false for all combinations,
since the value sets for CONCURRENCY and TYPE are disjoint, and the
old client basically tries to match concurrency against type. So old
clients will not crash. This should remove Kathey's concern, I hope :)

A new client against and old server will work, but give wrong results,
although wrong in a different way from before. It would now return
true in some cases, where it previosuly always returned false. Those
"true" value though, would mostly be wrong, cf. old server's values:

       TYPE_FORWARD_ONLY,CONCUR_UPDATABLE;\
       TYPE_SCROLL_INSENSITIVE,CONCUR_UPDATABLE;\
       TYPE_SCROLL_SENSITIVE,CONCUR_READ_ONLY,CONCUR_UPDATABLE 

So it would give wrong values, but the old behavior (Always false) was
wrong too.. I think this is acceptable.


> DatabaseMetadata method supportsResultSetConcurrency returns wrong result on network
client
> -------------------------------------------------------------------------------------------
>
>          Key: DERBY-965
>          URL: http://issues.apache.org/jira/browse/DERBY-965
>      Project: Derby
>         Type: Bug
>   Components: Network Server, Network Client
>     Versions: 10.2.0.0
>  Environment: Solaris 10, x86, Sun JDK 1.4.2
>     Reporter: Dag H. Wanvik
>     Assignee: Dag H. Wanvik
>     Priority: Minor
>  Attachments: Main.java, derby965-v1.diff, derby965-v1.stat
>
> The DatabaseMetaData method supportsResultSetConcurrency erroneously
> returns false on the network client for all arguments combination, cf
> the attached repro program. The embedded client returns correct
> results, viz the output:
> org.apache.derby.jdbc.ClientDriver:
> SupportsResultSetConcurrency: TYPE_FORWARD_ONLY,CONCUR_READ_ONLY: false
> SupportsResultSetConcurrency: TYPE_FORWARD_ONLY,CONCUR_UPDATABLE: false
> SupportsResultSetConcurrency: TYPE_SCROLL_INSENSITIVE,CONCUR_READ_ONLY: false
> SupportsResultSetConcurrency: TYPE_SCROLL_INSENSITIVE,CONCUR_UPDATABLE: false
> SupportsResultSetConcurrency: TYPE_SCROLL_SENSITIVE,CONCUR_READ_ONLY: false
> SupportsResultSetConcurrency: TYPE_SCROLL_SENSITIVE,CONCUR_UPDATABLE: false
> org.apache.derby.jdbc.EmbeddedDriver:
> SupportsResultSetConcurrency: TYPE_FORWARD_ONLY,CONCUR_READ_ONLY: true
> SupportsResultSetConcurrency: TYPE_FORWARD_ONLY,CONCUR_UPDATABLE: true
> SupportsResultSetConcurrency: TYPE_SCROLL_INSENSITIVE,CONCUR_READ_ONLY: true
> SupportsResultSetConcurrency: TYPE_SCROLL_INSENSITIVE,CONCUR_UPDATABLE: false
> SupportsResultSetConcurrency: TYPE_SCROLL_SENSITIVE,CONCUR_READ_ONLY: false
> SupportsResultSetConcurrency: TYPE_SCROLL_SENSITIVE,CONCUR_UPDATABLE: false
> Presumably, this is wrong in released versions as well.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message