db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Van Couvering (JIRA)" <derby-...@db.apache.org>
Subject [jira] Commented: (DERBY-819) Provide JDBC4 SQLException subclasses support in Embedded driver
Date Thu, 16 Feb 2006 20:12:09 GMT
    [ http://issues.apache.org/jira/browse/DERBY-819?page=comments#action_12366669 ] 

David Van Couvering commented on DERBY-819:

Hi, Anurag.  This is looking really good.  Just a few small comments:

- Maybe I have this wrong, but is there value in storing the exception factory in a local
variable, and just referring to that, rather than calling the InternalDriver.getExceptionFactory()
method each time?  

- In Util.java, you still have notImplemented() and you indicate that the client driver uses
it. I would recommend removing this, and linking this bug to the JIRA item which fixes the
network client, and say that this JIRA is blocked by the network client bug.

- The getExceptionFactory method in Driver should have a javadoc explaining its purpose.

- the generateCsSQLException() calls in InternalDriver have indents that cause the code to
go way over 80 characters, it would be great if you could fix this.

- In SystemProcedures.java you replace "IN REPLACE SMALLINT" with "IN? REPLACE SMALLINT",
and add question marks elsewhere.  Can you explain these changes, and how they are related
to the SQLException work?



> Provide JDBC4 SQLException subclasses support in Embedded driver
> ----------------------------------------------------------------
>          Key: DERBY-819
>          URL: http://issues.apache.org/jira/browse/DERBY-819
>      Project: Derby
>         Type: Sub-task
>   Components: JDBC
>  Environment: all
>     Reporter: Anurag Shekhar
>     Assignee: Anurag Shekhar
>     Priority: Minor
>  Attachments: .derby-819_2.stat, derby-819-onlyforreview.diff, derby-819.diff, derby-819_2.diff,

This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
For more information on JIRA, see:

View raw message