db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel John Debrunner (JIRA)" <derby-...@db.apache.org>
Subject [jira] Commented: (DERBY-819) Provide JDBC4 SQLException subclasses support in Embedded driver
Date Thu, 16 Feb 2006 22:17:10 GMT
    [ http://issues.apache.org/jira/browse/DERBY-819?page=comments#action_12366696 ] 

Daniel John Debrunner commented on DERBY-819:
---------------------------------------------

more review on derby819_2.diff 

I would like to see some comments in the code indicating what functionality is lost by using
the standard SQL exceptions rather than EmbedSQLException. I agree this is the way forward,
but what are embedded applications losing when they switch to JDBC 4.0. EmbedSQLException
must be providing some value, otherwise the code would have used SQLException. 


Ignore my previous comment about this issue:
- Seems to be some unrelated changes included, addition of an extra parameter here.

-            throw Util.generateCsSQLException(SQLState.INVALID_API_PARAMETER,map,"map",
+            throw InternalDriver.getExceptionFactory()
+            .generateCsSQLException(SQLState.INVALID_API_PARAMETER,map,"map",
                                               "java.sql.Connection.setTypeMap");

Mis-read the diff, sorry.

> Provide JDBC4 SQLException subclasses support in Embedded driver
> ----------------------------------------------------------------
>
>          Key: DERBY-819
>          URL: http://issues.apache.org/jira/browse/DERBY-819
>      Project: Derby
>         Type: Sub-task
>   Components: JDBC
>  Environment: all
>     Reporter: Anurag Shekhar
>     Assignee: Anurag Shekhar
>     Priority: Minor
>  Attachments: .derby-819_2.stat, derby-819-onlyforreview.diff, derby-819.diff, derby-819_2.diff,
stat.out
>


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message