db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel John Debrunner (JIRA)" <derby-...@db.apache.org>
Subject [jira] Commented: (DERBY-819) Provide JDBC4 SQLException subclasses support in Embedded driver
Date Fri, 17 Feb 2006 00:00:25 GMT
    [ http://issues.apache.org/jira/browse/DERBY-819?page=comments#action_12366723 ] 

Daniel John Debrunner commented on DERBY-819:
---------------------------------------------

- I think the changes to SystemProcedure are in comments, so I don't think it would affect
derbyall, but the changes are wrong.

- yes the model you propose is simpler, though I wouldn't have every call to getExceptionFactory()
 check to see if the factory is null,
   just ensure the static initiailizer sets up the static factory variable.

- "the code" - I meant the Derby engine code in general. Does EmbeddedSQLException provide
additional functionality that is not in SQLException.  I think it does, or at least maybe
did.  I seem  to remember that:

         1) It makes the printed stack trace be the stack trace of the underlying exception,
for more natural debugging.
           (maybe the initCause() method added in JDK 1.4 addresses this)

          2) The toString()  method doesn't print out the class name, this was an issue when
Cloudscape was obfuscated because we could not deal with the class name appearing in the test
diffs, since the name could change on each obfuscation run.
            This one leads to a good question, does derbyall pass in jdk16 with this change?

- I think the fourth point goes back to the second. If this is separate classes, which is
probably a good idea then it should be totally separated from InternalDriver, and become a
simple factory model. While it is linked with InternalDriver, it looks more natural to combine
them. Maybe Driver40 when it is booted could swap the factory instance for a JDBC 3.0 one
to a JDBC 4.0 one.

> Provide JDBC4 SQLException subclasses support in Embedded driver
> ----------------------------------------------------------------
>
>          Key: DERBY-819
>          URL: http://issues.apache.org/jira/browse/DERBY-819
>      Project: Derby
>         Type: Sub-task
>   Components: JDBC
>  Environment: all
>     Reporter: Anurag Shekhar
>     Assignee: Anurag Shekhar
>     Priority: Minor
>  Attachments: .derby-819_2.stat, derby-819-onlyforreview.diff, derby-819.diff, derby-819_2.diff,
stat.out
>


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message