Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm
Precedence: bulk
Reply-To: <derby-dev@db.apache.org>
Received-SPF: pass (asf.osuosl.org: local policy)
Date: Wed, 11 Jan 2006 08:41:06 +0100
From: Knut Anders Hatlen <Knut.Hatlen@Sun.COM>
Subject: Re: [jira] Updated: (DERBY-212) Optimize some specific methods in
 Network Server to improve performance
In-reply-to: <43C48922.5060808@amberpoint.com>
To: derby-dev@db.apache.org
Message-id: <wjo8mzi3tdnx.fsf@sun.com>
Organization: Sun Microsystems
MIME-version: 1.0
Content-type: text/plain; charset=us-ascii
User-Agent: Gnus/5.1007 (Gnus v5.10.7) Emacs/21.4 (usg-unix-v)
References: <623785402.1136818794080.JavaMail.jira@ajax.apache.org>
 <43C48922.5060808@amberpoint.com>

Bryan Pendleton <bpendleton@amberpoint.com> writes:

> Knut Anders Hatlen (JIRA) wrote:
>> I have uploaded a new patch (DERBY-212-parsePKGNAMCSN-2.diff) where I
>> have tried to address Bryan's review comments.
>
> Hi Knut Anders,
>
> I read through your changes and they look good to me. Thanks for
> taking the time to investigate my comments. I have no further
> comments or suggestions.

Thanks again for reading my patch, Bryan. 

> How does the performance look with these latest changes? Are the
> results with this patch more or less in line with your expectations?

It seems like the simplification of DRDAString had a small positive
effect, but it's hard to say exactly since the (imagined) increase was
at about the same size as the noise. The other changes had very little
impact on the performance, so I think the readability changes were
worthwhile.

Then we'll just have to wait for a committer's attention. Any
volunteers? :)

-- 
Knut Anders