Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm
Precedence: bulk
Reply-To: <derby-dev@db.apache.org>
Received-SPF: neutral (asf.osuosl.org: local policy)
Message-ID: <43D68C9B.10501@sbcglobal.net>
Date: Tue, 24 Jan 2006 12:22:51 -0800
From: Mike Matrigali <mikem_app@sbcglobal.net>
User-Agent: Mozilla Thunderbird 0.7.2 (Windows/20040707)
MIME-Version: 1.0
To: derby-dev@db.apache.org
Subject: Re: [jira] Updated: (DERBY-665) Remove backup(File ...) methods
References: <1898055160.1138069892465.JavaMail.jira@ajax.apache.org>
In-Reply-To: <1898055160.1138069892465.JavaMail.jira@ajax.apache.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

I am looking at committing this patch.

Suresh Thalamati (JIRA) wrote:

>      [ http://issues.apache.org/jira/browse/DERBY-665?page=all ]
> 
> Suresh Thalamati updated DERBY-665:
> -----------------------------------
> 
>     Attachment: derby665.diff
> 
> This patch removes  the unused bacpup  functions with File  as paramteter, 
> TESTS : derbyall test suite passed on Windows XP/JDK142
> 
> It would be great if some can review and commit this patch. 
> 
> 
> svn stat:
> M      java\engine\org\apache\derby\impl\db\BasicDatabase.java
> M      java\engine\org\apache\derby\impl\store\access\RAMAccessManager.java
> M      java\engine\org\apache\derby\impl\store\raw\RawStore.java
> M      java\engine\org\apache\derby\iapi\store\access\AccessFactory.java
> M      java\engine\org\apache\derby\iapi\store\raw\RawStoreFactory.java
> M      java\engine\org\apache\derby\database\Database.java
> 
> 
> 
>>Remove backup(File ...) methods
>>-------------------------------
>>
>>         Key: DERBY-665
>>         URL: http://issues.apache.org/jira/browse/DERBY-665
>>     Project: Derby
>>        Type: Improvement
>>  Components: Store
>>    Versions: 10.2.0.0
>> Environment: Any
>>    Reporter: Øystein Grøvlen
>>    Assignee: Suresh Thalamati
>>    Priority: Minor
>> Attachments: derby665.diff
>>
>>The code contains backup methods both for specifying the backup directory both as a String and as a File parameter.  Only the String versions are currently used.  The File versions should be removed to avoid duplication of code etc.
>>Examples of such methods are:
>>BasicDatabase.backup
>>BasicDatabase.backupAndEnableLogArchiveMode
>>RAMAccessManager.backup
>>RAMAccessManager.backupAndEnableLogArchiveMode
>>RawStore.backupAndEnableLogArchiveMode
>>plus corresponding interfaces.
> 
>